Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: net/url_request/url_request.h

Issue 12701011: [Net] Propagate priority changes from URLRequest to HttpTransaction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 5580b63eef8925633345c155f356b403b120a26d..72c3ddf1a110a346725da5505acb21c4487ecff9 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/debug/leak_tracker.h"
+#include "base/gtest_prod_util.h"
#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/string16.h"
@@ -615,11 +616,9 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// Returns the priority level for this request.
RequestPriority priority() const { return priority_; }
- void set_priority(RequestPriority priority) {
- DCHECK_GE(priority, MINIMUM_PRIORITY);
- DCHECK_LT(priority, NUM_PRIORITIES);
- priority_ = priority;
- }
+
+ // Sets the priority level for this request and any related jobs.
+ void SetPriority(RequestPriority priority);
// Returns true iff this request would be internally redirected to HTTPS
// due to HSTS. If so, |redirect_url| is rewritten to the new HTTPS URL.
@@ -662,6 +661,8 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
private:
friend class URLRequestJob;
+ FRIEND_TEST_ALL_PREFIXES(URLRequestTest, Priority);
mmenke 2013/03/12 18:40:22 I don't believe this is currently needed.
akalin 2013/03/12 22:08:28 Not after addressing your other comments. Done.
mmenke 2013/03/12 22:58:26 Oops - yea, comment was wrong. I missed the last
+
// Registers a new protocol handler for the given scheme. If the scheme is
// already handled, this will overwrite the given factory. To delete the
// protocol factory, use NULL for the factory BUT this WILL NOT put back

Powered by Google App Engine
This is Rietveld 408576698