[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
 #include "base/debug/leak_tracker.h"
+#include "base/gtest_prod_util.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "base/supports_user_data.h"
 #include "base/time.h"
 #include "base/threading/non_thread_safe.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
 #include "net/base/load_states.h"
@@ skipping 586 matching lines @@
   // Used to specify the context (cookie store, cache) for this request.
   const URLRequestContext* context() const;
 
   const BoundNetLog& net_log() const { return net_log_; }
 
   // Returns the expected content size if available
   int64 GetExpectedContentSize() const;
 
   // Returns the priority level for this request.
   RequestPriority priority() const { return priority_; }
-  void set_priority(RequestPriority priority) {
-    DCHECK_GE(priority, MINIMUM_PRIORITY);
-    DCHECK_LT(priority, NUM_PRIORITIES);
-    priority_ = priority;
-  }
+
+  // Sets the priority level for this request and any related jobs.
+  void SetPriority(RequestPriority priority);
 
   // Returns true iff this request would be internally redirected to HTTPS
   // due to HSTS. If so, |redirect_url| is rewritten to the new HTTPS URL.
   bool GetHSTSRedirect(GURL* redirect_url) const;
 
   // TODO(willchan): Undo this. Only temporarily public.
   bool has_delegate() const { return delegate_ != NULL; }
 
   // NOTE(willchan): This is just temporary for debugging
   // http://crbug.com/90971.
@@ skipping 22 matching lines @@
   // Called by URLRequestJob to allow interception when a redirect occurs.
   void NotifyReceivedRedirect(const GURL& location, bool* defer_redirect);
 
   // Allow an interceptor's URLRequestJob to restart this request.
   // Should only be called if the original job has not started a response.
   void Restart();
 
  private:
   friend class URLRequestJob;
 
+  FRIEND_TEST_ALL_PREFIXES(URLRequestTest, Priority);

[mmenke, 2013/03/12 18:40:22]

I don't believe this is currently needed.

[akalin, 2013/03/12 22:08:28]

Not after addressing your other comments.  Done.

[mmenke, 2013/03/12 22:58:26]

Oops - yea, comment was wrong.  I missed the last file in my first pass.

+
   // Registers a new protocol handler for the given scheme. If the scheme is
   // already handled, this will overwrite the given factory. To delete the
   // protocol factory, use NULL for the factory BUT this WILL NOT put back
   // any previously registered protocol factory. It will have returned
   // the previously registered factory (or NULL if none is registered) when
   // the scheme was first registered so that the caller can manually put it
   // back if desired.
   //
   // The scheme must be all-lowercase ASCII. See the ProtocolFactory
   // declaration for its requirements.
@@ skipping 165 matching lines @@
   LoadTimingInfo load_timing_info_;
 
   scoped_ptr<const base::debug::StackTrace> stack_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_