Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270093004: Relax debug check to allow for type arguments of a canonical signature type to (Closed)

Created:
5 years, 4 months ago by regis
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Relax debug check to allow for type arguments of a canonical signature type to be bounded.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M runtime/vm/object.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
There is actually no bug, just a debug check that is too strict.
5 years, 4 months ago (2015-08-04 19:45:27 UTC) #2
rmacnak
LGTM
5 years, 4 months ago (2015-08-04 20:59:53 UTC) #3
regis
5 years, 4 months ago (2015-08-04 22:38:34 UTC) #4 
On 2015/08/04 20:59:53, rmacnak wrote:
> LGTM

Thanks!

I (thought I) committed this change a while back and flushed my branch.
But it is nowhere to be found. I probably missed an error while committing.
Let me patch this back in a new branch and submit again.

Powered by Google App Engine
This is Rietveld 408576698