Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api
Patch Set: Addressed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index a93eea7e70809ddf518856e59d4eeb4eb79a8e96..b1e1b23e429d6827fb3f82df335c8c47a6b49016 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2778,6 +2778,7 @@ void WebContentsImpl::SetFocusToLocationBar(bool select_all) {
}
void WebContentsImpl::DidStartNavigation(NavigationHandle* navigation_handle) {
+ static_cast<NavigationHandleImpl*>(navigation_handle)->set_web_contents(this);
nasko 2015/09/14 22:00:04 Is this the only usage of set_web_contents? Can we
clamy 2015/09/14 22:12:10 Well if I have a handy way to get to the WebConten
Charlie Reis 2015/09/16 00:09:24 Yeah, this is one of the tricky aspects of having
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
DidStartNavigation(navigation_handle));
}

Powered by Google App Engine
This is Rietveld 408576698