content/public/browser/content_browser_client.h - Issue 1269813002: Add a NavigationThrottle to the public content/ interface

Unified Diff: content/public/browser/content_browser_client.h

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/content_tests.gypi ('k') | content/public/browser/content_browser_client.cc » ('j') | content/public/browser/navigation_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index 1644592758b718833a987b235ef7032982291fd4..2b7127c363629d40a6c51986c515978cdacb6010 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -16,6 +16,7 @@

#include "base/memory/scoped_vector.h"

#include "base/values.h"

#include "content/public/browser/certificate_request_result_type.h"

+#include "content/public/browser/navigation_throttle.h"

#include "content/public/common/content_client.h"

#include "content/public/common/media_stream_request.h"

#include "content/public/common/resource_type.h"

@@ -98,6 +99,7 @@ class LocationProvider;

class MediaObserver;

class NavigatorConnectContext;

class NavigatorConnectServiceFactory;

+class NavigationHandle;

Charlie Reis 2015/09/11 00:06:48 nit: Alphabetize.

clamy 2015/09/16 01:03:21 Done.

class PlatformNotificationService;

class PresentationServiceDelegate;

class QuotaPermissionContext;

@@ -667,6 +669,13 @@ class CONTENT_EXPORT ContentBrowserClient {

// Allows the embedder to record |metric| for a specific |url|.

virtual void RecordURLMetric(const std::string& metric, const GURL& url) {}

+ // Allows the embedder to register one or more NavigationThrottles for a

+ // navigation. A NavigationThrottle is used to control the flow of a

Charlie Reis 2015/09/11 00:06:48 nit: for the navigation indicated by |navigation_h

clamy 2015/09/16 01:03:21 Done.

+ // navigation on the UI thread. The embedder is guaranteed that the throttles

+ // will be executed in the order they were provided.

+ virtual ScopedVector<NavigationThrottle> GetNavigationThrottles(

Charlie Reis 2015/09/11 00:06:48 "GetNavigationThrottles" sounds like an accessor f

clamy 2015/09/16 01:03:21 Done.

+ NavigationHandle* navigation_handle);

// Populates |mappings| with all files that need to be mapped before launching

// a child process.

#if defined(OS_ANDROID)