Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/common/mac/mock_launchd.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator_browsertest.mm ('k') | chrome/common/metrics/version_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/mac/mock_launchd.cc
diff --git a/chrome/common/mac/mock_launchd.cc b/chrome/common/mac/mock_launchd.cc
index 8aebf44b98a01d12855585cc6d5608daa8a3a7b0..b4e80ec5851927f210e3f7a35c8462c27bbe49cb 100644
--- a/chrome/common/mac/mock_launchd.cc
+++ b/chrome/common/mac/mock_launchd.cc
@@ -17,9 +17,9 @@
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/sys_string_conversions.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/common/mac/launchd.h"
#include "chrome/common/service_process_util.h"
+#include "components/version_info/version_info.h"
#include "testing/gtest/include/gtest/gtest.h"
static sockaddr_un* throwaway_sockaddr_un;
@@ -49,8 +49,6 @@ bool MockLaunchd::MakeABundle(const base::FilePath& dst,
return false;
}
- chrome::VersionInfo version_info;
-
const char info_plist_format[] =
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
"<!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" "
@@ -75,7 +73,7 @@ bool MockLaunchd::MakeABundle(const base::FilePath& dst,
base::StringPrintf(info_plist_format,
name.c_str(),
name.c_str(),
- version_info.Version().c_str());
+ version_info::GetVersionNumber().c_str());
len = info_plist_data.length();
if (base::WriteFile(info_plist, info_plist_data.c_str(), len) != len) {
return false;
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator_browsertest.mm ('k') | chrome/common/metrics/version_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698