Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6767)

Unified Diff: chrome/common/mac/app_mode_chrome_locator_browsertest.mm

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/gcm_desktop_util.cc ('k') | chrome/common/mac/mock_launchd.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/mac/app_mode_chrome_locator_browsertest.mm
diff --git a/chrome/common/mac/app_mode_chrome_locator_browsertest.mm b/chrome/common/mac/app_mode_chrome_locator_browsertest.mm
index 2e79980250497ad1236e5746714063152cb580d6..1603c3323ac2cef4c0c51df860cfb4642b5bc43e 100644
--- a/chrome/common/mac/app_mode_chrome_locator_browsertest.mm
+++ b/chrome/common/mac/app_mode_chrome_locator_browsertest.mm
@@ -11,7 +11,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/path_service.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/chrome_version_info.h"
+#include "components/version_info/version_info.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -84,7 +84,7 @@ TEST(ChromeLocatorTest, GetChromeBundleInfoWithLatestVersion) {
base::FilePath version_path;
base::FilePath framework_path;
EXPECT_TRUE(app_mode::GetChromeBundleInfo(chrome_bundle_path,
- chrome::VersionInfo().Version(),
+ version_info::GetVersionNumber(),
&executable_path,
&version_path,
&framework_path));
@@ -121,8 +121,9 @@ TEST(ChromeLocatorTest, GetChromeBundleInfoWithPreviousVersion) {
base::FilePath fake_version_directory = chrome_bundle_path.Append("Contents")
.Append("Versions")
.Append("previous_version");
- EXPECT_TRUE(base::CreateSymbolicLink(
- base::FilePath(chrome::VersionInfo().Version()), fake_version_directory));
+ EXPECT_TRUE(
+ base::CreateSymbolicLink(base::FilePath(version_info::GetVersionNumber()),
+ fake_version_directory));
base::FilePath executable_path;
base::FilePath version_path;
« no previous file with comments | « chrome/common/gcm_desktop_util.cc ('k') | chrome/common/mac/mock_launchd.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698