Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/memory_details_mac.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/media_capture_devices_dispatcher.cc ('K') | « chrome/browser/media/webrtc_logging_handler_host.cc ('k') | chrome/browser/memory_details_win.cc » ('j') | chrome/browser/metrics/variations/variations_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory_details_mac.cc
diff --git a/chrome/browser/memory_details_mac.cc b/chrome/browser/memory_details_mac.cc
index d87eea20b86473564a7ee5d069daa0902b5223f0..89ae9c1cfb9b3fe3b777cff52f486be5d235756c 100644
--- a/chrome/browser/memory_details_mac.cc
+++ b/chrome/browser/memory_details_mac.cc
@@ -18,9 +18,9 @@
#include "base/threading/thread.h"
#include "chrome/browser/process_info_snapshot.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/chromium_strings.h"
+#include "components/version_info/version_info.h"
#include "content/public/browser/browser_child_process_host.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/common/process_type.h"
@@ -63,9 +63,8 @@ void CollectProcessDataForChromeProcess(
else
info.process_type = content::PROCESS_TYPE_UNKNOWN;
- chrome::VersionInfo version_info;
- info.product_name = base::ASCIIToUTF16(version_info.Name());
- info.version = base::ASCIIToUTF16(version_info.Version());
+ info.product_name = base::ASCIIToUTF16(version_info::GetProductName());
+ info.version = base::ASCIIToUTF16(version_info::GetVersionNumber());
// Check if this is one of the child processes whose data was already
// collected and exists in |child_data|.
« chrome/browser/media/media_capture_devices_dispatcher.cc ('K') | « chrome/browser/media/webrtc_logging_handler_host.cc ('k') | chrome/browser/memory_details_win.cc » ('j') | chrome/browser/metrics/variations/variations_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698