Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4426)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/media_capture_devices_dispatcher.cc ('K') | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/memory_details_mac.cc » ('j') | chrome/browser/metrics/variations/variations_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_logging_handler_host.cc
diff --git a/chrome/browser/media/webrtc_logging_handler_host.cc b/chrome/browser/media/webrtc_logging_handler_host.cc
index e97f9992e1974d5bfb75a7ddd6b157fc388e6a77..1a354c3ae8f9ea03bea7fc30baf40b82b11a0427 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.cc
+++ b/chrome/browser/media/webrtc_logging_handler_host.cc
@@ -22,10 +22,11 @@
#include "chrome/browser/media/webrtc_log_uploader.h"
#include "chrome/browser/media/webrtc_rtp_dump_handler.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/channel_info.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/common/media/webrtc_logging_messages.h"
#include "chromeos/settings/cros_settings_names.h"
+#include "components/version_info/version_info.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/gpu_data_manager.h"
@@ -573,9 +574,8 @@ void WebRtcLoggingHandlerHost::LogInitialInfoOnIOThread(
}
// Chrome version
- chrome::VersionInfo version_info;
- LogToCircularBuffer("Chrome version: " + version_info.Version() + " " +
- chrome::VersionInfo::GetVersionStringModifier());
+ LogToCircularBuffer("Chrome version: " + version_info::GetVersionNumber() +
+ " " + chrome::GetChannelString());
// OS
LogToCircularBuffer(base::SysInfo::OperatingSystemName() + " " +
« chrome/browser/media/media_capture_devices_dispatcher.cc ('K') | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/memory_details_mac.cc » ('j') | chrome/browser/metrics/variations/variations_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698