Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1269753002: GC: Add tracing event for rescanning large objects on newspace evacuation (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GC: Add tracing event for rescanning large objects on newspace evacuation BUG= Committed: https://crrev.com/b2f56b8599ae6c158eceb1508e7585b8840028a5 Cr-Commit-Position: refs/heads/master@{#29945}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/heap/gc-tracer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Lippautz
5 years, 4 months ago (2015-07-30 14:57:36 UTC) #2
Hannes Payer (out of office)
lgtm, with one nit https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h#newcode107 src/heap/gc-tracer.h:107: MC_SWEEP_RESCAN_LARGE_OBJECTS, This is actually not ...
5 years, 4 months ago (2015-07-31 06:51:53 UTC) #3
Michael Lippautz
https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1269753002/diff/20001/src/heap/gc-tracer.h#newcode107 src/heap/gc-tracer.h:107: MC_SWEEP_RESCAN_LARGE_OBJECTS, On 2015/07/31 06:51:53, Hannes Payer wrote: > This ...
5 years, 4 months ago (2015-07-31 06:54:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269753002/40001
5 years, 4 months ago (2015-07-31 06:55:46 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-31 07:29:37 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 07:29:58 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b2f56b8599ae6c158eceb1508e7585b8840028a5
Cr-Commit-Position: refs/heads/master@{#29945}

Powered by Google App Engine
This is Rietveld 408576698