Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1269673003: CFI: Enable stack traces in renderer process in non-official CFI builds. (Closed)

Created:
5 years, 4 months ago by pcc1
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, rickyz+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CFI: Enable stack traces in renderer process in non-official CFI builds. A CFI failure causes a SIGILL signal to be raised, and the most likely place for a failure to occur is in the renderer. By printing a stack trace we provide developers with a basic set of information about CFI failures, and allow crashes to be disambiguated by ClusterFuzz. BUG=464797 R=jln@chromium.org,jam@chromium.org Committed: https://crrev.com/ed9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa Cr-Commit-Position: refs/heads/master@{#341833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/sandbox_linux/sandbox_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
pcc1
5 years, 4 months ago (2015-07-30 20:49:55 UTC) #1
pcc1
Ping.
5 years, 4 months ago (2015-08-04 20:20:16 UTC) #2
jln (very slow on Chromium)
lgtm (But I'm not Nico)
5 years, 4 months ago (2015-08-04 20:25:57 UTC) #3
pcc1
On 2015/08/04 20:25:57, jln wrote: > lgtm (But I'm not Nico) Thanks. Adding jam@ for ...
5 years, 4 months ago (2015-08-04 20:37:24 UTC) #5
jam
lgtm
5 years, 4 months ago (2015-08-04 23:08:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269673003/1
5 years, 4 months ago (2015-08-04 23:13:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 00:47:35 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 00:48:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa
Cr-Commit-Position: refs/heads/master@{#341833}

Powered by Google App Engine
This is Rietveld 408576698