content/common/sandbox_linux/sandbox_linux.cc - Issue 1269673003: CFI: Enable stack traces in renderer process in non-official CFI builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_linux/sandbox_linux.cc

Issue 1269673003: CFI: Enable stack traces in renderer process in non-official CFI builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/sandbox_linux/sandbox_linux.cc

diff --git a/content/common/sandbox_linux/sandbox_linux.cc b/content/common/sandbox_linux/sandbox_linux.cc

index b2a7b3e6e960a0d824e123544510bfb5332acd14..952772ee648634f796e2aa4879461709a50ea69b 100644

--- a/content/common/sandbox_linux/sandbox_linux.cc

+++ b/content/common/sandbox_linux/sandbox_linux.cc

@@ -140,7 +140,7 @@ void LinuxSandbox::PreinitializeSandbox() {

sanitizer_args_.reset();

#endif

-#if !defined(NDEBUG)

+#if !defined(NDEBUG) || (defined(CFI_ENFORCEMENT) && !defined(OFFICIAL_BUILD))

// The in-process stack dumping needs to open /proc/self/maps and cache

// its contents before the sandbox is enabled. It also pre-opens the

// object files that are already loaded in the process address space.

« no previous file with comments | « no previous file | content/renderer/renderer_main.cc » ('j') | no next file with comments »