Create a utility for running executables in LAA mode.

Create a utility for running executables in LAA mode.

This allows launching binaries from the command-line with a configured LargeAddressAware mode. This will be used as a harness to run certain unittests in both 2G and 4G modes.

BUG=
R=sebmarchand@chromium.org

Committed: https://github.com/google/syzygy/commit/969f63df6cde7283a005984b7bca1d92c9b0e4a9

[chrisha, 2015-07-29 19:59:53]

chrisha@chromium.org changed reviewers:
+ sebmarchand@chromium.org

[chrisha, 2015-07-29 19:59:54]

PTAL?

[Sébastien Marchand, 2015-07-30 18:23:28]

lgtm with one comment.

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app_un...
File syzygy/runlaa/runlaa_app_unittest.cc (right):

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app_un...
syzygy/runlaa/runlaa_app_unittest.cc:51: CreateTemporaryDir(&temp_dir_);
The stream redirection could probably be extracted into a unittest_util file
somewhere (or in a member function of PELibUnitTest), there's 25 copy of these
lines in our codebase...

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app_un...
syzygy/runlaa/runlaa_app_unittest.cc:57: exe_path_ =
testing::GetExeRelativePath(L"runlaa.exe");
This is such a boring name :)

[chrisha, 2015-07-30 20:06:12]

Thanks, committing.

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app_un...
File syzygy/runlaa/runlaa_app_unittest.cc (right):

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app_un...
syzygy/runlaa/runlaa_app_unittest.cc:51: CreateTemporaryDir(&temp_dir_);
On 2015/07/30 18:23:28, Sébastien Marchand wrote:
> The stream redirection could probably be extracted into a unittest_util file
> somewhere (or in a member function of PELibUnitTest), there's 25 copy of these
> lines in our codebase...

I've filed a bug to clean this up.

[chrisha, 2015-07-30 21:12:02]

Committed patchset #1 (id:1) manually as
969f63df6cde7283a005984b7bca1d92c9b0e4a9 (presubmit successful).

[Sigurður Ásgeirsson, 2015-08-03 10:27:28]

siggi@chromium.org changed reviewers:
+ siggi@chromium.org

[Sigurður Ásgeirsson, 2015-08-03 10:27:29]

late nits.

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc
File syzygy/runlaa/runlaa_app.cc (right):

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc...
syzygy/runlaa/runlaa_app.cc:192: bool is_laa = false;
nit: was_laa to make subsequent code more readable?

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc...
syzygy/runlaa/runlaa_app.cc:221: // the
nit: yuck!

[chrisha, 2015-08-03 13:13:46]

Thanks for the drive-by. Addressing these nits over here:

https://codereview.chromium.org/1261453003/

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc
File syzygy/runlaa/runlaa_app.cc (right):

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc...
syzygy/runlaa/runlaa_app.cc:192: bool is_laa = false;
On 2015/08/03 10:27:28, Sigurður Ásgeirsson wrote:
> nit: was_laa to make subsequent code more readable?

Done.

https://codereview.chromium.org/1269553002/diff/1/syzygy/runlaa/runlaa_app.cc...
syzygy/runlaa/runlaa_app.cc:221: // the
On 2015/08/03 10:27:28, Sigurður Ásgeirsson wrote:
> nit: yuck!

Done.