Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: syzygy/runlaa/runlaa_app.h

Issue 1269553002: Create a utility for running executables in LAA mode. (Closed) Base URL: https://github.com/google/syzygy.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/runlaa/runlaa_app.h
diff --git a/syzygy/poirot/poirot_app.h b/syzygy/runlaa/runlaa_app.h
similarity index 51%
copy from syzygy/poirot/poirot_app.h
copy to syzygy/runlaa/runlaa_app.h
index fd807fdeff493b9b522fac98f37b415157ead0f4..4095021608cf5e9810ad4390397d20a06a620546 100644
--- a/syzygy/poirot/poirot_app.h
+++ b/syzygy/runlaa/runlaa_app.h
@@ -11,50 +11,43 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
+//
+// Defines the RunLaaApp class which implements a command-line tool for
+// running applications with Large Address Aware mode enabled or disabled.
-#ifndef SYZYGY_POIROT_POIROT_APP_H_
-#define SYZYGY_POIROT_POIROT_APP_H_
+#ifndef SYZYGY_RUNLAA_RUNLAA_APP_H_
+#define SYZYGY_RUNLAA_RUNLAA_APP_H_
#include "base/command_line.h"
#include "base/files/file_path.h"
-#include "base/strings/string_piece.h"
#include "syzygy/application/application.h"
-#include "syzygy/poirot/minidump_processor.h"
-namespace poirot {
+namespace runlaa {
-// This class implements the minidump processor command-line utility.
-//
-// See the description given in PoirotApp:::PrintUsage() for
-// information about running this utility.
-class PoirotApp : public application::AppImplBase {
+class RunLaaApp : public application::AppImplBase {
public:
+ RunLaaApp()
+ : AppImplBase("RunLAA"),
+ is_laa_(false),
+ in_place_(false),
+ keep_temp_dir_(false) {}
+
// @name Implementation of the AppImplBase interface.
// @{
- PoirotApp() : application::AppImplBase("PoirotApp") {}
-
bool ParseCommandLine(const base::CommandLine* command_line);
-
int Run();
// @}
+ // Exposed for unittesting.
protected:
- // @name Utility function
- // @{
- void PrintUsage(const base::FilePath& program,
- const base::StringPiece& message);
- // @}
-
- // @name Command-line options.
- // @{
- base::FilePath input_minidump_;
- base::FilePath output_file_;
- // @}
-
- private:
- DISALLOW_COPY_AND_ASSIGN(PoirotApp);
+ std::string expect_mode_;
+ base::FilePath image_;
+ bool is_laa_;
+ bool in_place_;
+ bool keep_temp_dir_;
+ base::CommandLine::StringVector child_argv_;
};
-} // namespace poirot
+} // namespace runlaa
-#endif // SYZYGY_POIROT_POIROT_APP_H_
+#endif // SYZYGY_RUNLAA_RUNLAA_APP_H_

Powered by Google App Engine
This is Rietveld 408576698