Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1269543002: buildbot_spec.py: Add Android/ChromeOS device info, add builder_cfg dict (Closed)

Created:
5 years, 4 months ago by borenet
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

buildbot_spec.py: Add Android/ChromeOS device info, add builder_cfg dict NOTRY=true BUG=skia:4132 Committed: https://skia.googlesource.com/skia/+/7bccca1a8269ff94984dc86b5ad7e5f673238699

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -1 line) Patch
M tools/buildbot_spec.json View 13 chunks +248 lines, -0 lines 0 comments Download
M tools/buildbot_spec.py View 3 chunks +53 lines, -1 line 2 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
borenet
I'm doing this incrementally in Skia repo to keep things easy to review. On the ...
5 years, 4 months ago (2015-07-29 17:02:59 UTC) #2
mtklein
I did not look at the .json file. lgtm https://codereview.chromium.org/1269543002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1269543002/diff/1/tools/buildbot_spec.py#newcode174 tools/buildbot_spec.py:174: ...
5 years, 4 months ago (2015-07-29 18:07:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269543002/1
5 years, 4 months ago (2015-07-29 18:09:39 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 18:15:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7bccca1a8269ff94984dc86b5ad7e5f673238699

Powered by Google App Engine
This is Rietveld 408576698