Issue 1257933003: buildbot_spec.py: Include dm_flags and nanobench_flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257933003: buildbot_spec.py: Include dm_flags and nanobench_flags (Closed)

Created:
5 years, 4 months ago by borenet

Modified:
5 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@device_cfg

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

buildbot_spec.py: Include dm_flags and nanobench_flags Eventually I'll want to merge them into this file, but not just yet. NOTRY=true BUG=skia:4132 Committed: https://skia.googlesource.com/skia/+/2481b8b71941914ed053400700299f20f7ff32fc

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2952 lines, -20 lines)			Patch
	M	tools/buildbot_spec.json	View		20 chunks	+2948 lines, -20 lines	0 comments	Download
	M	tools/buildbot_spec.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1269543002 Patch 1

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

borenet

Depends on https://codereview.chromium.org/1269543002/ ("buildbot_spec.py: Add Android/ChromeOS device info, add builder_cfg dict")

5 years, 4 months ago (2015-07-29 17:08:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257933003/1

5 years, 4 months ago (2015-07-29 18:42:30 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-07-29 18:43:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2481b8b71941914ed053400700299f20f7ff32fc

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages