Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269413006: Fix ASAN error for wbmp swizzles (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
Reviewers:
scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ASAN error for wbmp swizzles BUG=skia: Committed: https://skia.googlesource.com/skia/+/cbb12ca953c8db8030e4e52bb12e2dae98d2692b

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M src/codec/SkSwizzler.cpp View 3 chunks +18 lines, -12 lines 1 comment Download

Depends on Patchset:

Issue 1188223002 Patch 1

Messages

Total messages: 7 (3 generated)
msarett
https://codereview.chromium.org/1269413006/diff/20001/src/codec/SkSwizzler.cpp File src/codec/SkSwizzler.cpp (left): https://codereview.chromium.org/1269413006/diff/20001/src/codec/SkSwizzler.cpp#oldcode46 src/codec/SkSwizzler.cpp:46: U8CPU currByte = src[i]; This reads out of bounds ...
5 years, 4 months ago (2015-08-05 20:39:08 UTC) #3
scroggo
lgtm
5 years, 4 months ago (2015-08-05 20:52:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269413006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269413006/20001
5 years, 4 months ago (2015-08-05 20:52:29 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 20:59:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/cbb12ca953c8db8030e4e52bb12e2dae98d2692b

Powered by Google App Engine
This is Rietveld 408576698