Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269323003: Cleanup unnecessary duplication of runtime functions. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup unnecessary duplication of runtime functions. R=yangguo@chromium.org Committed: https://crrev.com/899c4284d50603a6276a8bf5c988d30cdd192411 Cr-Commit-Position: refs/heads/master@{#30023}

Patch Set 1 #

Patch Set 2 : Adapt test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -106 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 6 chunks +2 lines, -9 lines 0 comments Download
M src/runtime/runtime-maths.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +10 lines, -16 lines 0 comments Download
M src/runtime/runtime-strings.cc View 5 chunks +3 lines, -21 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/string-compare-memcmp.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-05 10:39:37 UTC) #1
Yang
lgtm
5 years, 4 months ago (2015-08-05 10:52:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269323003/20001
5 years, 4 months ago (2015-08-05 11:12:01 UTC) #4
commit-bot: I haz the power
Failed to commit the patch.
5 years, 4 months ago (2015-08-05 11:14:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269323003/20001
5 years, 4 months ago (2015-08-05 11:18:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 11:20:47 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 11:22:28 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/899c4284d50603a6276a8bf5c988d30cdd192411
Cr-Commit-Position: refs/heads/master@{#30023}

Powered by Google App Engine
This is Rietveld 408576698