src/compiler/simplified-lowering.cc - Issue 1269323003: Cleanup unnecessary duplication of runtime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1269323003: Cleanup unnecessary duplication of runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adapt test case. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 006b6ab28f26454149e19b3d9ae404c346e5f4a3..5ecd30c761a55318d68c83dfc3d84ac2908ba0d7 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -1341,7 +1341,7 @@ void SimplifiedLowering::DoStoreElement(Node* node) {

Node* SimplifiedLowering::StringComparison(Node* node, bool requires_ordering) {

Runtime::FunctionId f =

- requires_ordering ? Runtime::kStringCompareRT : Runtime::kStringEquals;

+ requires_ordering ? Runtime::kStringCompare : Runtime::kStringEquals;

ExternalReference ref(f, jsgraph()->isolate());

Operator::Properties props = node->op()->properties();

// TODO(mstarzinger): We should call StringCompareStub here instead, once an

« no previous file with comments | « src/compiler/linkage.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »