Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 double valueAsDate(bool& isNull) const; 131 double valueAsDate(bool& isNull) const;
132 void setValueAsDate(double, ExceptionState&); 132 void setValueAsDate(double, ExceptionState&);
133 133
134 double valueAsNumber() const; 134 double valueAsNumber() const;
135 void setValueAsNumber(double, ExceptionState&, TextFieldEventBehavior = Disp atchNoEvent); 135 void setValueAsNumber(double, ExceptionState&, TextFieldEventBehavior = Disp atchNoEvent);
136 136
137 String valueWithDefault() const; 137 String valueWithDefault() const;
138 138
139 void setValueFromRenderer(const String&); 139 void setValueFromRenderer(const String&);
140 140
141 int selectionStartForBinding(ExceptionState&) const; 141 unsigned selectionStartForBinding(ExceptionState&) const;
142 int selectionEndForBinding(ExceptionState&) const; 142 unsigned selectionEndForBinding(ExceptionState&) const;
143 String selectionDirectionForBinding(ExceptionState&) const; 143 String selectionDirectionForBinding(ExceptionState&) const;
144 void setSelectionStartForBinding(int, ExceptionState&); 144 void setSelectionStartForBinding(int, ExceptionState&);
145 void setSelectionEndForBinding(int, ExceptionState&); 145 void setSelectionEndForBinding(int, ExceptionState&);
146 void setSelectionDirectionForBinding(const String&, ExceptionState&); 146 void setSelectionDirectionForBinding(const String&, ExceptionState&);
147 void setSelectionRangeForBinding(int start, int end, ExceptionState&); 147 void setSelectionRangeForBinding(int start, int end, ExceptionState&);
148 void setSelectionRangeForBinding(int start, int end, const String& direction , ExceptionState&); 148 void setSelectionRangeForBinding(int start, int end, const String& direction , ExceptionState&);
149 149
150 bool layoutObjectIsNeeded(const ComputedStyle&) final; 150 bool layoutObjectIsNeeded(const ComputedStyle&) final;
151 LayoutObject* createLayoutObject(const ComputedStyle&) override; 151 LayoutObject* createLayoutObject(const ComputedStyle&) override;
152 void detach(const AttachContext& = AttachContext()) final; 152 void detach(const AttachContext& = AttachContext()) final;
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 // The ImageLoader must be owned by this element because the loader code ass umes 389 // The ImageLoader must be owned by this element because the loader code ass umes
390 // that it lives as long as its owning element lives. If we move the loader into 390 // that it lives as long as its owning element lives. If we move the loader into
391 // the ImageInput object we may delete the loader while this element lives o n. 391 // the ImageInput object we may delete the loader while this element lives o n.
392 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader; 392 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
393 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r; 393 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r;
394 }; 394 };
395 395
396 } // namespace blink 396 } // namespace blink
397 397
398 #endif // HTMLInputElement_h 398 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/selection-start-end-readonly-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698