Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: LayoutTests/fast/css/focus-ring-recursive-continuations.html

Issue 1269123002: Preparation for combining paths of focus rings and outlines (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove debug from fast/css/focus-ring-recursive-continuations.html Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css/focus-ring-recursive-continuations.html
diff --git a/LayoutTests/fast/css/focus-ring-recursive-continuations.html b/LayoutTests/fast/css/focus-ring-recursive-continuations.html
index 2ece4631730c9ccb879f631a674ba35e2b6e315b..d6021ccafcc9af54db173d28857aa51618f79798 100644
--- a/LayoutTests/fast/css/focus-ring-recursive-continuations.html
+++ b/LayoutTests/fast/css/focus-ring-recursive-continuations.html
@@ -4,14 +4,15 @@
description('When adding focus ring rects, we should avoid adding duplicated rect for continuations');
onload = function() {
document.body.offsetTop;
- // 5 focus ring rects:
+ // 6 focus ring rects:
// - 0: 'SPAN0' part of the span;
// - 1: div DIV1
- // - 2: first line box of div DIV1
- // - 3: div DIV2
- // - 4: first line box of div DIV2
+ // - 2: anonymous block containing the inline part of DIV1 before DIV2
+ // - 3: first line box of div DIV1
+ // - 4: div DIV2
+ // - 5: first line box of div DIV2
if (window.testRunner && window.internals)
- shouldBe("internals.focusRingRects(document.getElementById('focus'))", "5");
+ shouldBe("internals.outlineRects(document.getElementById('focus')).length", "6");
chrishtr 2015/08/05 03:57:50 Why are there now 6? Was this test just busted?
Xianzhu 2015/08/05 15:58:42 Actually there is no behavior change, but the test
};
</script>
<div>

Powered by Google App Engine
This is Rietveld 408576698