LayoutTests/fast/css/focus-ring-recursive-continuations.html - Issue 1269123002: Preparation for combining paths of focus rings and outlines

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/focus-ring-recursive-continuations.html

Issue 1269123002: Preparation for combining paths of focus rings and outlines (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove debug from fast/css/focus-ring-recursive-continuations.html Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/css/focus-ring-recursive-continuations-expected.txt » ('j') | LayoutTests/platform/linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description('When adding focus ring rects, we should avoid adding duplicated rec t for continuations');	4 description('When adding focus ring rects, we should avoid adding duplicated rec t for continuations');

5 onload = function() {	5 onload = function() {

6 document.body.offsetTop;	6 document.body.offsetTop;

7 // 5 focus ring rects:	7 // 6 focus ring rects:

8 // - 0: 'SPAN0' part of the span;	8 // - 0: 'SPAN0' part of the span;

9 // - 1: div DIV1	9 // - 1: div DIV1

10 // - 2: first line box of div DIV1	10 // - 2: anonymous block containing the inline part of DIV1 before DIV2

11 // - 3: div DIV2	11 // - 3: first line box of div DIV1

12 // - 4: first line box of div DIV2	12 // - 4: div DIV2

	13 // - 5: first line box of div DIV2

13 if (window.testRunner && window.internals)	14 if (window.testRunner && window.internals)

14 shouldBe("internals.focusRingRects(document.getElementById('focus'))", "5");	15 shouldBe("internals.outlineRects(document.getElementById('focus')).length", "6");
	chrishtr 2015/08/05 03:57:50 Why are there now 6? Was this test just busted? Why are there now 6? Was this test just busted? Xianzhu 2015/08/05 15:58:42 Actually there is no behavior change, but the test Show quoted text On 2015/08/05 03:57:50, chrishtr wrote: > Why are there now 6? Was this test just busted? Actually there is no behavior change, but the test was written wrongly and had a wrong baseline.
15 };	16 };

16 </script>	17 </script>

17 <div>	18 <div>

18 <span id="focus">SPAN0	19 <span id="focus">SPAN0

19 <div>DIV1	20 <div>DIV1

20 <span>SPAN1	21 <span>SPAN1

21 <div>DIV2</div>	22 <div>DIV2</div>

22 </span>	23 </span>

23 </div>	24 </div>

24 </span>	25 </span>

25 </div>	26 </div>

OLD	NEW