Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1269083005: [Android] Reland CommandLine reset listeners. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
Yaron, dgn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reland CommandLine reset listeners. This is a reland of https://codereview.chromium.org/1254973003, which I had reverted in https://codereview.chromium.org/1263433002 because I thought all calls to FeatureUtilities.isDocumentMode would now happen after CommandLineFlags.setUp was called. This was mistaken and has broken L bots. BUG=516421 TBR=yfriedman@chromium.org,dgn@chromium.org Committed: https://crrev.com/cb98f483a972190366ba611e34563d44e5288676 Cr-Commit-Position: refs/heads/master@{#341639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M base/android/java/src/org/chromium/base/CommandLine.java View 4 chunks +25 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 4 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbudorick
TBR: fixing L bots.
5 years, 4 months ago (2015-08-03 23:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269083005/1
5 years, 4 months ago (2015-08-03 23:20:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 23:25:17 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 23:25:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb98f483a972190366ba611e34563d44e5288676
Cr-Commit-Position: refs/heads/master@{#341639}

Powered by Google App Engine
This is Rietveld 408576698