[Android] Move @CommandLineFlag setup to BaseInstrumentationTestRunner.

[Android] Move @CommandLineFlag setup to BaseInstrumentationTestRunner.

This also reverts https://codereview.chromium.org/1254973003

BUG=514155
Committed: https://crrev.com/79ceab3c164e3719b8c4ae055502d7d394ceafa0
Cr-Commit-Position: refs/heads/master@{#341406}

[jbudorick, 2015-07-27 23:10:45]

jbudorick@chromium.org changed reviewers:
+ dgn@chromium.org, yfriedman@chromium.org

[dgn, 2015-07-30 11:51:57]

https://codereview.chromium.org/1263433002/diff/40001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
(right):

https://codereview.chromium.org/1263433002/diff/40001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java:54:
public void initCommandLine() {
Isn't this method called from CommandLineFlags#setUp() ? How did it not throw
the exception before? And then, do we need to still call it in onCreate() here?

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
File
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
(right):

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java:13:
* This class currently does nothing.
Any plans with it in the future? Why not removing it then? CS returns only 5
hits.

[Yaron, 2015-07-30 14:48:37]

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
File
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
(right):

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java:13:
* This class currently does nothing.
On 2015/07/30 11:51:57, dgn wrote:
> Any plans with it in the future? Why not removing it then? CS returns only 5
> hits.

Looks like it's only used in chromium so sgtm

[jbudorick, 2015-07-30 16:11:46]

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
File
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
(right):

https://codereview.chromium.org/1263433002/diff/40001/base/test/android/javat...
base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java:13:
* This class currently does nothing.
On 2015/07/30 at 14:48:37, Yaron wrote:
> On 2015/07/30 11:51:57, dgn wrote:
> > Any plans with it in the future? Why not removing it then? CS returns only 5
> > hits.
> 
> Looks like it's only used in chromium so sgtm

skirmani is planning on using it in an upcoming CL, so I'd like to leave it in
for now. If that changes, I'll be happy to remove it.

[Yaron, 2015-07-30 17:34:15]

lgtm

[jbudorick, 2015-07-31 20:51:37]

jbudorick@chromium.org changed reviewers:
+ boliu@chromium.org

[jbudorick, 2015-07-31 20:51:38]

+boliu for android_webview owners

https://codereview.chromium.org/1263433002/diff/40001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
(right):

https://codereview.chromium.org/1263433002/diff/40001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java:54:
public void initCommandLine() {
On 2015/07/30 at 11:51:57, dgn wrote:
> Isn't this method called from CommandLineFlags#setUp() ? How did it not throw
the exception before? And then, do we need to still call it in onCreate() here?

Seems that mnaganov revised the initialization of AwShellApplication in
https://codereview.chromium.org/1262393003, so I no longer have to change
anything here.

[boliu, 2015-07-31 20:55:10]

rs lgtm

[jbudorick, 2015-07-31 20:55:27]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2015-07-31 20:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1263433002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-31 20:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263433002/60001

[commit-bot: I haz the power, 2015-07-31 21:01:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-31 21:02:35]

Patchset 4 (id:??) landed as
https://crrev.com/79ceab3c164e3719b8c4ae055502d7d394ceafa0
Cr-Commit-Position: refs/heads/master@{#341406}