Issue 1269073003: CPDF_Parser shouldnt be in the business of opening files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1269073003: CPDF_Parser shouldnt be in the business of opening files (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

CPDF_Parser shouldnt be in the business of opening files Move that operation closer to the embedder's call. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2b9178181eb82a3611bee5c9435ea5956def24be

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -17 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 4 months ago (2015-08-05 17:39:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b9178181eb82a3611bee5c9435ea5956def24be (presubmit successful).