core/include/fpdfapi/fpdf_parser.h - Issue 1269073003: CPDF_Parser shouldnt be in the business of opening files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_parser.h

Issue 1269073003: CPDF_Parser shouldnt be in the business of opening files (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_parser.h

diff --git a/core/include/fpdfapi/fpdf_parser.h b/core/include/fpdfapi/fpdf_parser.h

index f80bb24a87a218bdbad3324ced031b3109bb80d0..7640c857fa48b3e8dab7bde5b36fecc70bbd3aa7 100644

--- a/core/include/fpdfapi/fpdf_parser.h

+++ b/core/include/fpdfapi/fpdf_parser.h

@@ -355,8 +355,6 @@ class CPDF_Parser {

CPDF_Parser();

~CPDF_Parser();

- FX_DWORD StartParse(const FX_CHAR* filename, FX_BOOL bReParse = FALSE);

- FX_DWORD StartParse(const FX_WCHAR* filename, FX_BOOL bReParse = FALSE);

FX_DWORD StartParse(IFX_FileRead* pFile,

FX_BOOL bReParse = FALSE,

FX_BOOL bOwnFileRead = TRUE);

« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp » ('j') | no next file with comments »