Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268953002: Make ANGLE perf decisions be runtime rather than compile time (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixrpspeed
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make ANGLE perf decisions be runtime rather than compile time R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/88c7b988ba7792e51e741567426069cd9cc852dd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M include/gpu/gl/GrGLConfig.h View 2 chunks +0 lines, -17 lines 0 comments Download
M include/gpu/gl/GrGLConfig_chrome.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 3 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 4 months ago (2015-07-31 17:04:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268953002/1
5 years, 4 months ago (2015-07-31 17:11:16 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-07-31 17:11:17 UTC) #4
robertphillips
lgtm + some code organization suggestions https://codereview.chromium.org/1268953002/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1268953002/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode308 src/gpu/gl/GrGLCaps.cpp:308: Can we just ...
5 years, 4 months ago (2015-07-31 17:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268953002/20001
5 years, 4 months ago (2015-07-31 18:13:11 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 18:20:18 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/88c7b988ba7792e51e741567426069cd9cc852dd

Powered by Google App Engine
This is Rietveld 408576698