include/gpu/gl/GrGLConfig_chrome.h - Issue 1268953002: Make ANGLE perf decisions be runtime rather than compile time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/gpu/gl/GrGLConfig_chrome.h

Issue 1268953002: Make ANGLE perf decisions be runtime rather than compile time (Closed) Base URL: https://skia.googlesource.com/skia.git@fixrpspeed

Patch Set: Address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/gpu/gl/GrGLConfig_chrome.h

diff --git a/include/gpu/gl/GrGLConfig_chrome.h b/include/gpu/gl/GrGLConfig_chrome.h

index ee875b7f22e049aaa3ddcb0c021febc8890b51b1..041a46d8c405e770bfd2b40b3199bc50eead6648 100644

--- a/include/gpu/gl/GrGLConfig_chrome.h

+++ b/include/gpu/gl/GrGLConfig_chrome.h

@@ -11,17 +11,6 @@

// glGetError() forces a sync with gpu process on chrome

#define GR_GL_CHECK_ERROR_START 0

-#if defined(SK_BUILD_FOR_WIN32)

-// For RGBA teximage/readpixels ANGLE will sw-convert to/from BGRA.

-#define GR_GL_RGBA_8888_PIXEL_OPS_SLOW 1

-// ANGLE can go faster if the entire fbo is read rather than a subrect

-#define GR_GL_FULL_READPIXELS_FASTER_THAN_PARTIAL 1

-#else

-#define GR_GL_RGBA_8888_PIXEL_OPS_SLOW 0

-#define GR_GL_FULL_READPIXELS_FASTER_THAN_PARTIAL 0

-#endif

// cmd buffer allocates memory and memsets it to zero when it sees glBufferData

// with NULL.

#define GR_GL_USE_BUFFER_DATA_NULL_HINT 0

« no previous file with comments | « include/gpu/gl/GrGLConfig.h ('k') | src/gpu/gl/GrGLCaps.h » ('j') | no next file with comments »