Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1268883002: Version 4.4.63.26 (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Version 4.4.63.26 [crankshaft] Fix wrong bailout points in for-in loop body. This is a manual port of https://codereview.chromium.org/1183683004, which fixed the same issue on the 4.5 branch. BUG=chromium:514268 LOG=n R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/18ac1f2635e30dc4f1eac7e16f9f43974a935874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-514268.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
5 years, 4 months ago (2015-07-31 09:32:23 UTC) #1
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-07-31 09:54:58 UTC) #2
Jakob Kummerow
5 years, 4 months ago (2015-07-31 10:38:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18ac1f2635e30dc4f1eac7e16f9f43974a935874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698