Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1183683004: [crankshaft] Fix wrong bailout points in for-in loop body. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix wrong bailout points in for-in loop body. R=jochen@chromium.org BUG=chromium:500435 LOG=y Committed: https://crrev.com/45439b92e716d3501d2029b1e79cac2c6efe2ecb Cr-Commit-Position: refs/heads/master@{#29040}

Patch Set 1 #

Patch Set 2 : Test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/hydrogen.cc View 1 chunk +4 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-500435.js View 1 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-16 07:26:59 UTC) #1
jochen (gone - plz use gerrit)
test?
5 years, 6 months ago (2015-06-16 07:28:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-16 07:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183683004/20001
5 years, 6 months ago (2015-06-16 07:38:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 08:08:39 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 08:08:48 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45439b92e716d3501d2029b1e79cac2c6efe2ecb
Cr-Commit-Position: refs/heads/master@{#29040}

Powered by Google App Engine
This is Rietveld 408576698