Move webstorePrivate DelegatedInstall functions into new dashboardPrivate API

Move webstorePrivate DelegatedInstall functions into new dashboardPrivate API

Skipping presubmit to allow the histogram enum rename.
NOPRESUBMIT=true

BUG=515912
Committed: https://crrev.com/cccaba669cfe08b83e0a082203533285aec8c9be
Cr-Commit-Position: refs/heads/master@{#341351}

[Marc Treib, 2015-07-31 10:56:52]

treib@chromium.org changed reviewers:
+ kalman@chromium.org

[Marc Treib, 2015-07-31 10:56:52]

PTAL!

[Marc Treib, 2015-07-31 10:59:38]

...as discussed in https://codereview.chromium.org/1260983002/

[not at google - send to devlin, 2015-07-31 14:42:20]

lgtm with a couple of comments. Note you'll probably need NOPRESUBMIT=true or
the histogram rename will fail.

https://codereview.chromium.org/1268853003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
(right):

https://codereview.chromium.org/1268853003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h:39:
using Params =
Does it make sense to have this in the private: section?

https://codereview.chromium.org/1268853003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/1268853003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/_api_features.json:257:
"B44D08FD98F1523ED5837D78D0A606EA9D6206E5"  // Web Store
What does the webstore need from this?

https://codereview.chromium.org/1268853003/diff/20001/extensions/renderer/dis...
File extensions/renderer/dispatcher.cc (right):

https://codereview.chromium.org/1268853003/diff/20001/extensions/renderer/dis...
extensions/renderer/dispatcher.cc:1159: // Hard-code that the app and webstore
APIs are available...
Could you fix this comment: "Hard-code registration of any APIs that are exposed
to webpage-like contexts, because it's too expensive to run the full bindings
code. All of the same permission checks will still apply."

[Marc Treib, 2015-07-31 15:28:42]

https://codereview.chromium.org/1268853003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
(right):

https://codereview.chromium.org/1268853003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h:39:
using Params =
On 2015/07/31 14:42:20, kalman wrote:
> Does it make sense to have this in the private: section?

Yup, it does :)
Done.

https://codereview.chromium.org/1268853003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/1268853003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/_api_features.json:257:
"B44D08FD98F1523ED5837D78D0A606EA9D6206E5"  // Web Store
On 2015/07/31 14:42:20, kalman wrote:
> What does the webstore need from this?

The webstore also needs to call this API - remote install is possible from both
the webstore and our dashboard. (That's basically the reason why this was in
webstorePrivate in the first place.)
Or was the question "why isn't the URL pattern above sufficient"? Because the
webstore is not in a web_page context, and if I add "blessed_extension" above,
then the API will be available to any extension.

Or alternatively, I might have misunderstood something, in which case please
correct me :)

https://codereview.chromium.org/1268853003/diff/20001/extensions/renderer/dis...
File extensions/renderer/dispatcher.cc (right):

https://codereview.chromium.org/1268853003/diff/20001/extensions/renderer/dis...
extensions/renderer/dispatcher.cc:1159: // Hard-code that the app and webstore
APIs are available...
On 2015/07/31 14:42:20, kalman wrote:
> Could you fix this comment: "Hard-code registration of any APIs that are
exposed
> to webpage-like contexts, because it's too expensive to run the full bindings
> code. All of the same permission checks will still apply."

Done.

[Marc Treib, 2015-07-31 15:28:55]

treib@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Marc Treib, 2015-07-31 15:28:55]

+asvitkine for extension_function_histogram_value.h and histograms.xml. PTAL -
it's just a simple rename.

[Alexei Svitkine (slow), 2015-07-31 15:33:00]

lgtm

[Marc Treib, 2015-07-31 15:51:00]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-07-31 15:51:01]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1268853003/#ps40001
(title: "review")

[commit-bot: I haz the power, 2015-07-31 15:51:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268853003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268853003/40001

[commit-bot: I haz the power, 2015-07-31 16:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 16:02:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marc Treib, 2015-07-31 16:04:01]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2015-07-31 16:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268853003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268853003/40001

[commit-bot: I haz the power, 2015-07-31 17:01:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-31 17:02:25]

Patchset 3 (id:??) landed as
https://crrev.com/cccaba669cfe08b83e0a082203533285aec8c9be
Cr-Commit-Position: refs/heads/master@{#341351}