Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 126883005: Revert 242936 "When stopping QTKit video capture, call stopRunni..." (Closed)

Created:
6 years, 11 months ago by bemasc
Modified:
6 years, 11 months ago
Reviewers:
bemasc
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 242936 "When stopping QTKit video capture, call stopRunni..." This CL removed a deadlock on camera removal, but created a new one on shutdown while a camera is running. > When stopping QTKit video capture, call stopRunning before removeInput:. > > Empirically, this prevents a browser hang when the active camera is > unplugged. The unplug event triggers both stopping the capturer and > enumerating the available input devices at the same time. It seems > that calling removeInput: on a running capturer after an error > produces a deadlock, but stopping the capturer first resolves the > problem. > > BUG=285053 > > Review URL: https://codereview.chromium.org/120963003 TBR=bemasc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M trunk/src/media/video/capture/mac/video_capture_device_qtkit_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bemasc
6 years, 11 months ago (2014-01-08 00:29:06 UTC) #1
bemasc
6 years, 11 months ago (2014-01-08 00:29:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r243445.

Powered by Google App Engine
This is Rietveld 408576698