Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 120963003: When stopping QTKit video capture, call stopRunning before removeInput:. (Closed)

Created:
6 years, 11 months ago by bemasc
Modified:
6 years, 11 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

When stopping QTKit video capture, call stopRunning before removeInput:. Empirically, this prevents a browser hang when the active camera is unplugged. The unplug event triggers both stopping the capturer and enumerating the available input devices at the same time. It seems that calling removeInput: on a running capturer after an error produces a deadlock, but stopping the capturer first resolves the problem. BUG=285053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/video/capture/mac/video_capture_device_qtkit_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bemasc
6 years, 11 months ago (2014-01-02 23:59:50 UTC) #1
wjia(left Chromium)
lgtm
6 years, 11 months ago (2014-01-03 00:17:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/120963003/1
6 years, 11 months ago (2014-01-03 00:18:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) chromedriver2_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=209347
6 years, 11 months ago (2014-01-03 01:06:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/120963003/1
6 years, 11 months ago (2014-01-03 17:05:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) chromedriver2_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=207492
6 years, 11 months ago (2014-01-03 17:56:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/120963003/1
6 years, 11 months ago (2014-01-03 17:58:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) chromedriver2_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=207536
6 years, 11 months ago (2014-01-03 18:45:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bemasc@chromium.org/120963003/1
6 years, 11 months ago (2014-01-03 21:07:20 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-03 22:06:45 UTC) #10
Message was sent while issue was closed.
Change committed as 242936

Powered by Google App Engine
This is Rietveld 408576698