Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1268783004: VectorICs: refactoring to eliminate "for queries only" vector ic mode. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: refactoring to eliminate "for queries only" vector ic mode. Since we need the notion of a dummy vector ic, we can use that to avoid a special case of the IC constructor. Also, consolidate the two dummy ICs into one. BUG= Committed: https://crrev.com/1a5751f9b3ca682fadb6fce8202dda2db5b017c6 Cr-Commit-Position: refs/heads/master@{#29956}

Patch Set 1 : Patch One. #

Patch Set 2 : Ports. #

Patch Set 3 : Fix compilation error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -98 lines) Patch
M src/arm/builtins-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +9 lines, -17 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/ic/ic.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/type-feedback-vector.h View 4 chunks +29 lines, -9 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mvstanton
Thanks for the look, Yang!
5 years, 4 months ago (2015-07-31 12:38:04 UTC) #3
Yang
looking good so far. Maybe you can define the dummy as TypeFeedbackVector directly so you ...
5 years, 4 months ago (2015-07-31 13:14:58 UTC) #4
mvstanton
Ugh. It breaks the world because the ROOT_LIST needs the complete definition of TypeFeedbackVector and ...
5 years, 4 months ago (2015-07-31 13:26:19 UTC) #5
Yang
On 2015/07/31 13:26:19, mvstanton wrote: > Ugh. It breaks the world because the ROOT_LIST needs ...
5 years, 4 months ago (2015-07-31 13:44:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268783004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268783004/60001
5 years, 4 months ago (2015-07-31 13:45:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 4 months ago (2015-07-31 14:04:06 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 14:04:20 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a5751f9b3ca682fadb6fce8202dda2db5b017c6
Cr-Commit-Position: refs/heads/master@{#29956}

Powered by Google App Engine
This is Rietveld 408576698