Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: src/ic/ic.h

Issue 1268783004: VectorICs: refactoring to eliminate "for queries only" vector ic mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation error. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.h
diff --git a/src/ic/ic.h b/src/ic/ic.h
index b0a38c2f6dca5a5ddf8bbb1142080ad0bb1666c8..ee5fd261dc68c82be561010ce9770d82a25cea03 100644
--- a/src/ic/ic.h
+++ b/src/ic/ic.h
@@ -26,8 +26,7 @@ class IC {
// Construct the IC structure with the given number of extra
// JavaScript frames on the stack.
- IC(FrameDepth depth, Isolate* isolate, FeedbackNexus* nexus = NULL,
- bool for_queries_only = false);
+ IC(FrameDepth depth, Isolate* isolate, FeedbackNexus* nexus = NULL);
virtual ~IC() {}
State state() const { return state_; }
@@ -320,15 +319,6 @@ class LoadIC : public IC {
DCHECK(IsLoadStub());
}
- // TODO(mvstanton): The for_queries_only is because we have a case where we
- // construct an IC only to gather the contextual mode, and we don't have
- // vector/slot information. for_queries_only is a temporary hack to enable the
- // strong DCHECK protection around vector/slot.
- LoadIC(FrameDepth depth, Isolate* isolate, bool for_queries_only)
- : IC(depth, isolate, NULL, for_queries_only) {
- DCHECK(IsLoadStub());
- }
-
bool ShouldThrowReferenceError(Handle<Object> receiver) {
return receiver->IsGlobalObject() && typeof_mode() == NOT_INSIDE_TYPEOF;
}
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698