Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: runtime/vm/code_patcher_x64_test.cc

Issue 1268783003: Simplify constant pool usage in x64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_x64_test.cc
diff --git a/runtime/vm/code_patcher_x64_test.cc b/runtime/vm/code_patcher_x64_test.cc
index 9ba8d1f4c1c4fd77fe29fe3ae15e8610e48f8f3c..430b56d55c73b17f4894eccd88b40f5083780d8d 100644
--- a/runtime/vm/code_patcher_x64_test.cc
+++ b/runtime/vm/code_patcher_x64_test.cc
@@ -39,7 +39,10 @@ ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {
15,
1));
- __ LoadObject(RBX, ic_data, PP);
+ // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
+ __ set_constant_pool_allowed(true);
+
+ __ LoadObject(RBX, ic_data);
ExternalLabel target_label(StubCode::OneArgCheckInlineCacheEntryPoint());
__ CallPatchable(&target_label);
__ ret();
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698