Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: runtime/vm/code_patcher_x64_test.cc

Issue 1268783003: Simplify constant pool usage in x64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 21 matching lines...) Expand all
32 32
33 const String& target_name = String::Handle(String::New("targetFunction")); 33 const String& target_name = String::Handle(String::New("targetFunction"));
34 const Array& args_descriptor = 34 const Array& args_descriptor =
35 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array())); 35 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array()));
36 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function, 36 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function,
37 target_name, 37 target_name,
38 args_descriptor, 38 args_descriptor,
39 15, 39 15,
40 1)); 40 1));
41 41
42 __ LoadObject(RBX, ic_data, PP); 42 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
43 __ set_constant_pool_allowed(true);
44
45 __ LoadObject(RBX, ic_data);
43 ExternalLabel target_label(StubCode::OneArgCheckInlineCacheEntryPoint()); 46 ExternalLabel target_label(StubCode::OneArgCheckInlineCacheEntryPoint());
44 __ CallPatchable(&target_label); 47 __ CallPatchable(&target_label);
45 __ ret(); 48 __ ret();
46 } 49 }
47 50
48 51
49 ASSEMBLER_TEST_RUN(IcDataAccess, test) { 52 ASSEMBLER_TEST_RUN(IcDataAccess, test) {
50 uword return_address = test->entry() + CodePatcher::InstanceCallSizeInBytes(); 53 uword return_address = test->entry() + CodePatcher::InstanceCallSizeInBytes();
51 ICData& ic_data = ICData::Handle(); 54 ICData& ic_data = ICData::Handle();
52 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 55 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
53 EXPECT_STREQ("targetFunction", 56 EXPECT_STREQ("targetFunction",
54 String::Handle(ic_data.target_name()).ToCString()); 57 String::Handle(ic_data.target_name()).ToCString());
55 EXPECT_EQ(1, ic_data.NumArgsTested()); 58 EXPECT_EQ(1, ic_data.NumArgsTested());
56 EXPECT_EQ(0, ic_data.NumberOfChecks()); 59 EXPECT_EQ(0, ic_data.NumberOfChecks());
57 } 60 }
58 61
59 } // namespace dart 62 } // namespace dart
60 63
61 #endif // TARGET_ARCH_X64 64 #endif // TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698