Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 1268663003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink Layout 3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/update.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
diff --git a/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h b/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
index e835d8ab9290a4b4483a4ae508414951ad892157..a8895aa53c6f55f6e3a095bfd7add146b218d638 100644
--- a/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
+++ b/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
@@ -26,18 +26,7 @@ public:
virtual void proxyStopped() { }
virtual WebURL scope() const { return WebURL(); }
- // TODO(jungkees):
- // void update(p) remains temporarily before the chromium-side companion
- // patch lands: https://codereview.chromium.org/1270513002/.
- // Before the chromium-side patch lands, the new update(p, c) will
- // internally call update(provider) to work with the existing code base.
- // The final changes will be incorporated with the Blink layout patches.
- virtual void update(WebServiceWorkerProvider*) { }
- virtual void update(WebServiceWorkerProvider* provider, WebServiceWorkerUpdateCallbacks* callback)
- {
- update(provider);
- callback->onSuccess();
- }
+ virtual void update(WebServiceWorkerProvider*, WebServiceWorkerUpdateCallbacks*) { }
virtual void unregister(WebServiceWorkerProvider*, WebServiceWorkerUnregistrationCallbacks*) { }
};
« no previous file with comments | « LayoutTests/http/tests/serviceworker/update.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698