Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 1268663003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink Layout 3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/update.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebServiceWorkerRegistration_h 5 #ifndef WebServiceWorkerRegistration_h
6 #define WebServiceWorkerRegistration_h 6 #define WebServiceWorkerRegistration_h
7 7
8 #include "public/platform/WebCallbacks.h" 8 #include "public/platform/WebCallbacks.h"
9 #include "public/platform/WebServiceWorkerError.h" 9 #include "public/platform/WebServiceWorkerError.h"
10 #include "public/platform/WebURL.h" 10 #include "public/platform/WebURL.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class WebServiceWorkerProvider; 14 class WebServiceWorkerProvider;
15 class WebServiceWorkerRegistrationProxy; 15 class WebServiceWorkerRegistrationProxy;
16 16
17 class WebServiceWorkerRegistration { 17 class WebServiceWorkerRegistration {
18 public: 18 public:
19 virtual ~WebServiceWorkerRegistration() { } 19 virtual ~WebServiceWorkerRegistration() { }
20 20
21 using WebServiceWorkerUpdateCallbacks = WebCallbacks<void, const WebServiceW orkerError&>; 21 using WebServiceWorkerUpdateCallbacks = WebCallbacks<void, const WebServiceW orkerError&>;
22 using WebServiceWorkerUnregistrationCallbacks = WebCallbacks<bool, const Web ServiceWorkerError&>; 22 using WebServiceWorkerUnregistrationCallbacks = WebCallbacks<bool, const Web ServiceWorkerError&>;
23 23
24 virtual void setProxy(WebServiceWorkerRegistrationProxy*) { } 24 virtual void setProxy(WebServiceWorkerRegistrationProxy*) { }
25 virtual WebServiceWorkerRegistrationProxy* proxy() { return nullptr; } 25 virtual WebServiceWorkerRegistrationProxy* proxy() { return nullptr; }
26 virtual void proxyStopped() { } 26 virtual void proxyStopped() { }
27 27
28 virtual WebURL scope() const { return WebURL(); } 28 virtual WebURL scope() const { return WebURL(); }
29 // TODO(jungkees): 29 virtual void update(WebServiceWorkerProvider*, WebServiceWorkerUpdateCallbac ks*) { }
30 // void update(p) remains temporarily before the chromium-side companion
31 // patch lands: https://codereview.chromium.org/1270513002/.
32 // Before the chromium-side patch lands, the new update(p, c) will
33 // internally call update(provider) to work with the existing code base.
34 // The final changes will be incorporated with the Blink layout patches.
35 virtual void update(WebServiceWorkerProvider*) { }
36 virtual void update(WebServiceWorkerProvider* provider, WebServiceWorkerUpda teCallbacks* callback)
37 {
38 update(provider);
39 callback->onSuccess();
40 }
41 virtual void unregister(WebServiceWorkerProvider*, WebServiceWorkerUnregistr ationCallbacks*) { } 30 virtual void unregister(WebServiceWorkerProvider*, WebServiceWorkerUnregistr ationCallbacks*) { }
42 }; 31 };
43 32
44 } // namespace blink 33 } // namespace blink
45 34
46 #endif // WebServiceWorkerRegistration_h 35 #endif // WebServiceWorkerRegistration_h
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/serviceworker/update.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698