Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: LayoutTests/fast/multicol/transform-with-fixedpos-crash.html

Issue 1268493002: Unify code paths for fixed and absolutely positioned objects in accumulateOffsetTowardsAncestor(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/multicol/transform-with-fixedpos-crash.html
diff --git a/LayoutTests/fast/multicol/span/sole-svg-spanner-with-foreignObject-crash.html b/LayoutTests/fast/multicol/transform-with-fixedpos-crash.html
similarity index 61%
copy from LayoutTests/fast/multicol/span/sole-svg-spanner-with-foreignObject-crash.html
copy to LayoutTests/fast/multicol/transform-with-fixedpos-crash.html
index e196e060d739265cc9c500c025895f14d6915903..f94d2ec02276318f519e3b8484e8ec524501e413 100644
--- a/LayoutTests/fast/multicol/span/sole-svg-spanner-with-foreignObject-crash.html
+++ b/LayoutTests/fast/multicol/transform-with-fixedpos-crash.html
@@ -5,7 +5,7 @@
</script>
<p>PASS if no crash or assertion failure.</p>
Julien - ping for review 2015/07/29 23:10:52 Let's add a description of what is tested.
mstensho (USE GERRIT) 2015/07/30 09:32:06 Done.
<div style="-webkit-column-count:2;">
- <svg style="display:block; -webkit-column-span:all;">
- <foreignObject>&nbsp;</foreignObject>
- </svg>
+ <div style="-webkit-transform:rotate(4deg);">
+ <div style="position:fixed;"></div>
Julien - ping for review 2015/07/29 23:10:52 Ideally we would want to test that we get the *cor
mstensho (USE GERRIT) 2015/07/30 09:32:06 Done. Made a reftest instead. Note that there are
+ </div>
</div>

Powered by Google App Engine
This is Rietveld 408576698