LayoutTests/fast/multicol/transform-with-fixedpos-crash.html - Issue 1268493002: Unify code paths for fixed and absolutely positioned objects in accumulateOffsetTowardsAncestor().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/transform-with-fixedpos-crash.html

Issue 1268493002: Unify code paths for fixed and absolutely positioned objects in accumulateOffsetTowardsAncestor(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5 </script>	5 </script>

6 <p>PASS if no crash or assertion failure.</p>	6 <p>PASS if no crash or assertion failure.</p>
	Julien - ping for review 2015/07/29 23:10:52 Let's add a description of what is tested. Let's add a description of what is tested. mstensho (USE GERRIT) 2015/07/30 09:32:06 Done. Show quoted text On 2015/07/29 23:10:52, Julien Chaffraix - PST wrote: > Let's add a description of what is tested. Done.
7 <div style="-webkit-column-count:2;">	7 <div style="-webkit-column-count:2;">

8 <svg style="display:block; -webkit-column-span:all;">	8 <div style="-webkit-transform:rotate(4deg);">

9 <foreignObject> </foreignObject>	9 <div style="position:fixed;"></div>
	Julien - ping for review 2015/07/29 23:10:52 Ideally we would want to test that we get the cor Ideally we would want to test that we get the correct* result as assertions are disabled in release and it's also a more meaningful information that not crashing. mstensho (USE GERRIT) 2015/07/30 09:32:06 Done. Made a reftest instead. Note that there are Show quoted text On 2015/07/29 23:10:52, Julien Chaffraix - PST wrote: > Ideally we would want to test that we get the correct result as assertions are > disabled in release and it's also a more meaningful information that not > crashing. Done. Made a reftest instead. Note that there are still a bug with fixed-positioneds here, not related to this part of the code, so the test is somewhat crippled, in that it's boring enough to let everything take place in the first column, to avoid exposing other said bug. See bug 515415.
10 </svg>	10 </div>

11 </div>	11 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/transform-with-fixedpos-crash-expected.txt » ('j') | Source/core/paint/DeprecatedPaintLayer.cpp » ('J')