Issue 1268103003: Oilpan: have WebLocalFrameImpl use SelfKeepAlive<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1268103003: Oilpan: have WebLocalFrameImpl use SelfKeepAlive<>. (Closed)

Created:
5 years, 4 months ago by sof

Modified:
5 years, 4 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: have WebLocalFrameImpl use SelfKeepAlive<>. Canonicalize WebLocalFrameImpl's self-referential persistent as a SelfKeepAlive<>. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200038

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : improve/shorten comment #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	Source/web/WebLocalFrameImpl.h	View	1 2	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268103003/40001

5 years, 4 months ago (2015-08-05 07:49:52 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-05 07:53:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200038

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages