Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: Source/web/WebLocalFrameImpl.h

Issue 1268103003: Oilpan: have WebLocalFrameImpl use SelfKeepAlive<>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: improve/shorten comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 388
389 UserMediaClientImpl m_userMediaClientImpl; 389 UserMediaClientImpl m_userMediaClientImpl;
390 390
391 OwnPtrWillBeMember<GeolocationClientProxy> m_geolocationClientProxy; 391 OwnPtrWillBeMember<GeolocationClientProxy> m_geolocationClientProxy;
392 392
393 WebDevToolsFrontendImpl* m_webDevToolsFrontend; 393 WebDevToolsFrontendImpl* m_webDevToolsFrontend;
394 394
395 HashMap<AtomicString, OwnPtr<WebTestInterfaceFactory>> m_testInterfaces; 395 HashMap<AtomicString, OwnPtr<WebTestInterfaceFactory>> m_testInterfaces;
396 396
397 #if ENABLE(OILPAN) 397 #if ENABLE(OILPAN)
398 // Oilpan: to provide the guarantee of having the frame live until 398 // Oilpan: WebLocalFrameImpl must remain alive until close() is called.
399 // close() is called, an instance keep a self-persistent. It is 399 // Accomplish that by keeping a self-referential Persistent<>. It is
400 // cleared upon calling close(). This avoids having to assume that 400 // cleared upon close().
401 // an embedder's WebFrame references are all discovered via thread 401 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
402 // state (stack, registers) should an Oilpan GC strike while we're
403 // in the process of detaching.
404 GC_PLUGIN_IGNORE("340522")
405 Persistent<WebLocalFrameImpl> m_selfKeepAlive;
406 #endif 402 #endif
407 }; 403 };
408 404
409 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 405 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
410 406
411 } // namespace blink 407 } // namespace blink
412 408
413 #endif 409 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698