Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1268023003: Fix breakpad for arm on arm64 (Closed)

Created:
5 years, 4 months ago by cjhopman
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix breakpad for arm on arm64 On arm64 devices, GETFPREGS fails with errno==EIO. Ignore those failures on Android arm builds. BUG=508324 R=thestig@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1479

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M client/linux/minidump_writer/linux_ptrace_dumper.cc View 1 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
cjhopman
thestig: *
5 years, 4 months ago (2015-08-03 23:43:28 UTC) #2
Lei Zhang
https://codereview.chromium.org/1268023003/diff/1/client/linux/minidump_writer/linux_ptrace_dumper.cc File client/linux/minidump_writer/linux_ptrace_dumper.cc (right): https://codereview.chromium.org/1268023003/diff/1/client/linux/minidump_writer/linux_ptrace_dumper.cc#newcode209 client/linux/minidump_writer/linux_ptrace_dumper.cc:209: void* fp_addr; - I would just skip this entire ...
5 years, 4 months ago (2015-08-04 00:11:33 UTC) #3
cjhopman
https://codereview.chromium.org/1268023003/diff/1/client/linux/minidump_writer/linux_ptrace_dumper.cc File client/linux/minidump_writer/linux_ptrace_dumper.cc (right): https://codereview.chromium.org/1268023003/diff/1/client/linux/minidump_writer/linux_ptrace_dumper.cc#newcode209 client/linux/minidump_writer/linux_ptrace_dumper.cc:209: void* fp_addr; On 2015/08/04 00:11:33, Lei Zhang wrote: > ...
5 years, 4 months ago (2015-08-04 23:28:45 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1268023003/diff/20001/client/linux/minidump_writer/linux_ptrace_dumper.cc File client/linux/minidump_writer/linux_ptrace_dumper.cc (right): https://codereview.chromium.org/1268023003/diff/20001/client/linux/minidump_writer/linux_ptrace_dumper.cc#newcode220 client/linux/minidump_writer/linux_ptrace_dumper.cc:220: #endif nit: add // PTRACE_GETREGSET so it's more ...
5 years, 4 months ago (2015-08-04 23:39:34 UTC) #5
cjhopman
5 years, 4 months ago (2015-08-05 22:48:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698