[tracing] Throttle rate of heavy dumps and support to request light/heavy dumps

[tracing] Throttle rate of heavy dumps and support to request light/heavy dumps

Currently all the dump providers dump detailed dumps every periodic
dump. This makes the trace files huge. So, this CL throttles down the
rate of heavy dumps of all the dump providers and removes temporary
hacks. Along with this, this CL also adds support to request light and
heavy dumps by adding MemoryDumpArgs as param to RequestGlobalDump()

TBR=pfeldman@chromium.org
BUG=499731
Committed: https://crrev.com/33f2d3a5b276b70040adfd21edf364bd666b0aa2
Cr-Commit-Position: refs/heads/master@{#342145}

[ssid, 2015-08-03 16:06:15]

ssid@chromium.org changed reviewers:
+ petrcermak@chromium.org

[ssid, 2015-08-03 16:06:16]

PTAL. Thanks

[petrcermak, 2015-08-03 16:15:04]

Amazing job! LGTM with 2 comments!

Thanks,
Petr

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
File base/trace_event/memory_dump_manager.cc (right):

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
base/trace_event/memory_dump_manager.cc:65: MemoryDumpType dump_type =
MemoryDumpType::PERIODIC_INTERVAL;
nit: No need to declare this variable. You could just use the constant directly
on line 67.

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
File base/trace_event/memory_dump_manager_unittest.cc (right):

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
base/trace_event/memory_dump_manager_unittest.cc:215: // Check that requesting
dumps with low level of detail actually propagates to
This comment should be above line 212.

[petrcermak, 2015-08-03 16:15:05]

Amazing job! LGTM with 2 comments!

Thanks,
Petr

[ssid, 2015-08-03 16:24:09]

Thanks.

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
File base/trace_event/memory_dump_manager.cc (right):

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
base/trace_event/memory_dump_manager.cc:65: MemoryDumpType dump_type =
MemoryDumpType::PERIODIC_INTERVAL;
On 2015/08/03 16:15:03, petrcermak wrote:
> nit: No need to declare this variable. You could just use the constant
directly
> on line 67.

Done.

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
File base/trace_event/memory_dump_manager_unittest.cc (right):

https://codereview.chromium.org/1267963002/diff/20001/base/trace_event/memory...
base/trace_event/memory_dump_manager_unittest.cc:215: // Check that requesting
dumps with low level of detail actually propagates to
On 2015/08/03 16:15:03, petrcermak wrote:
> This comment should be above line 212.

Done.

[ssid, 2015-08-03 16:26:10]

ssid@chromium.org changed reviewers:
+ danakj@chromium.org

[ssid, 2015-08-03 16:26:11]

+danakj This is the second patch, related to crrev.com/1262333005.
PTAL, thanks.

[danakj, 2015-08-03 17:49:42]

On 2015/08/03 16:26:11, ssid wrote:
> +danakj This is the second patch, related to crrev.com/1262333005.
> PTAL, thanks.

Can you have OWNERS in base/trace_event review this?

[danakj, 2015-08-03 17:49:48]

danakj@chromium.org changed reviewers:
- danakj@chromium.org

[ssid, 2015-08-03 18:25:30]

ssid@chromium.org changed reviewers:
+ nduca@chromium.org

[ssid, 2015-08-03 18:25:31]

PTAL.

[nduca, 2015-08-04 15:47:42]

lgtm

[nduca, 2015-08-04 15:50:14]

lgtm

[ssid, 2015-08-04 17:12:24]

+pfeldman PTAL at tracing_handler.cc. It is just a 2 line change.

[ssid, 2015-08-04 17:13:34]

ssid@chromium.org changed reviewers:
+ pfeldman@chromium.org

[ssid, 2015-08-04 17:13:35]

+pfeldman PTAL at tracing_handler.cc. It is just a 2 line change

[pfeldman, 2015-08-06 17:57:38]

lgtm

[ssid, 2015-08-06 17:58:10]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-08-06 17:58:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org, nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1267963002/#ps80001
(title: "Fix win build.")

[commit-bot: I haz the power, 2015-08-06 17:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267963002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267963002/80001

[commit-bot: I haz the power, 2015-08-06 18:04:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-06 18:05:08]

Patchset 5 (id:??) landed as
https://crrev.com/33f2d3a5b276b70040adfd21edf364bd666b0aa2
Cr-Commit-Position: refs/heads/master@{#342145}

[waffles, 2015-08-06 19:00:59]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1272703003/ by waffles@chromium.org.

The reason for reverting is: Suspect it breaks Linux telemetry tests (or
possibly introduces flakiness):

Example
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/28807

telemetry.internal.backends.chrome_inspector.tracing_backend_unittest.TracingBackendMemoryTest.testDumpMemorySuccess
failed unexpectedly 0.2190s:
  Traceback (most recent call last):
    File
"/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py",
line 144, in testDumpMemorySuccess
      dump_id = self._browser.DumpMemory()
    File
"/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/browser/browser.py",
line 291, in DumpMemory
      return self._browser_backend.DumpMemory(timeout)
    File
"/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py",
line 321, in DumpMemory
      return self.devtools_client.DumpMemory(timeout)
    File
"/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py",
line 231, in DumpMemory
      return self._tracing_backend.DumpMemory(timeout)
    File
"/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py",
line 128, in DumpMemory
      'Tracing.requestMemoryDump:\n' + json.dumps(response, indent=2))
  TracingUnexpectedResponseException: Inspector returned unexpected response for
Tracing.requestMemoryDump:
  {
    "id": 2, 
    "error": {
      "message": "Tracing is not started", 
      "code": -32603
    }
  }.

[ssid, 2015-08-07 10:19:29]

Patchset #6 (id:100001) has been deleted

[ssid, 2015-08-07 10:19:36]

Patchset #7 (id:140001) has been deleted

[ssid, 2015-08-07 10:19:44]

Patchset #6 (id:120001) has been deleted

[ssid, 2016-09-07 03:46:58]

Patchset #4 (id:60001) has been deleted

[ssid, 2016-09-07 03:47:03]

Patchset #3 (id:40001) has been deleted