Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2682)

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 1267963002: [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@light_dumps
Patch Set: Fix win build. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.h
diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h
index e918a773a6d371aae386133b06ed8eb3e0d596c7..5c75e4e82e882b3e0f49b63f72ffc094496106e8 100644
--- a/base/trace_event/memory_dump_manager.h
+++ b/base/trace_event/memory_dump_manager.h
@@ -60,15 +60,18 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
// Requests a memory dump. The dump might happen or not depending on the
// filters and categories specified when enabling tracing.
+ // The |dump_args| is used to specify the dump's level of detail.
// The optional |callback| is executed asynchronously, on an arbitrary thread,
// to notify about the completion of the global dump (i.e. after all the
// processes have dumped) and its success (true iff all the dumps were
// successful).
void RequestGlobalDump(MemoryDumpType dump_type,
+ const MemoryDumpArgs& dump_args,
const MemoryDumpCallback& callback);
// Same as above (still asynchronous), but without callback.
- void RequestGlobalDump(MemoryDumpType dump_type);
+ void RequestGlobalDump(MemoryDumpType dump_type,
+ const MemoryDumpArgs& dump_args);
// TraceLog::EnabledStateObserver implementation.
void OnTraceLogEnabled() override;
« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698