chromeos: Stop dealing with metadata proto from DriveFileSystemTest

chromeos: Stop dealing with metadata proto from DriveFileSystemTest

DriveDirectoryProto is going to be deprecated, DriveFileSystemTest should not deal with it.

BUG=127856
TEST=unit_tests --gtest_filter="DriveFileSystemTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188710

[hidehiko, 2013-03-18 08:53:08]

https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right):

https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:420:
EXPECT_EQ(DRIVE_FILE_OK, error);
This is a kind of set up, how about checking the expectation before the test
itself. There are three ways, IIRC;
1) Return with boolean, and check with ASSERT_TRUE in the test body.
2) s/EXPECT_EQ/ASSERT_EQ/ and use ASSERT_NO_FATAL_FAILURE.
3) s/EXPECT_EQ/ASSERT_EQ/ and use HasFatalFailure.

Either looks fine to me, but according to grep, HasFatalFailure is rarely used,
so 1) or 2) may be better.

[hashimoto, 2013-03-18 09:10:04]

https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right):

https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:420:
EXPECT_EQ(DRIVE_FILE_OK, error);
On 2013/03/18 08:53:08, hidehiko wrote:
> This is a kind of set up, how about checking the expectation before the test
> itself. There are three ways, IIRC;
> 1) Return with boolean, and check with ASSERT_TRUE in the test body.
> 2) s/EXPECT_EQ/ASSERT_EQ/ and use ASSERT_NO_FATAL_FAILURE.
> 3) s/EXPECT_EQ/ASSERT_EQ/ and use HasFatalFailure.
> 
> Either looks fine to me, but according to grep, HasFatalFailure is rarely
used,
> so 1) or 2) may be better.

Done.
Return bool and assert the result.

[hidehiko, 2013-03-18 09:14:51]

lgtm

On 2013/03/18 09:10:04, hashimoto wrote:
>
https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
> File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right):
> 
>
https://codereview.chromium.org/12679008/diff/3001/chrome/browser/chromeos/dr...
> chrome/browser/chromeos/drive/drive_file_system_unittest.cc:420:
> EXPECT_EQ(DRIVE_FILE_OK, error);
> On 2013/03/18 08:53:08, hidehiko wrote:
> > This is a kind of set up, how about checking the expectation before the test
> > itself. There are three ways, IIRC;
> > 1) Return with boolean, and check with ASSERT_TRUE in the test body.
> > 2) s/EXPECT_EQ/ASSERT_EQ/ and use ASSERT_NO_FATAL_FAILURE.
> > 3) s/EXPECT_EQ/ASSERT_EQ/ and use HasFatalFailure.
> > 
> > Either looks fine to me, but according to grep, HasFatalFailure is rarely
> used,
> > so 1) or 2) may be better.
> 
> Done.
> Return bool and assert the result.

[hashimoto, 2013-03-18 10:20:26]

Committed patchset #3 manually as r188710 (presubmit successful).