Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3)

public/platform/WebServiceWorkerRegistration.h

Index: public/platform/WebServiceWorkerRegistration.h
diff --git a/public/platform/WebServiceWorkerRegistration.h b/public/platform/WebServiceWorkerRegistration.h
index 53790805cf2833d0e2d71d629bfa72f71e610844..a55d35f9e48181fde3be61c271d742c590a022aa 100644
--- a/public/platform/WebServiceWorkerRegistration.h
+++ b/public/platform/WebServiceWorkerRegistration.h
@@ -18,6 +18,7 @@ class WebServiceWorkerRegistration {
 public:
     virtual ~WebServiceWorkerRegistration() { }
 
+    using WebServiceWorkerUpdateCallbacks = WebCallbacks<void, WebServiceWorkerError*>;
     using WebServiceWorkerUnregistrationCallbacks = WebCallbacks<bool*, WebServiceWorkerError*>;
 
     virtual void setProxy(WebServiceWorkerRegistrationProxy*) { }
@@ -25,7 +26,14 @@ public:
     virtual void proxyStopped() { }
 
     virtual WebURL scope() const { return WebURL(); }
+    // TODO(jungkees):
+    // void update(p) remains temporarily before the chromium-side companion
+    // patch lands: https://codereview.chromium.org/1270513002/.
+    // Before the chromium-side patch lands, the new update(p, c) will
+    // internally call this->update(p) to work with the existing code base.
+    // The final changes will be incorporated with the Blink layout patches.
     virtual void update(WebServiceWorkerProvider*) { }
+    virtual void update(WebServiceWorkerProvider* provider, WebServiceWorkerUpdateCallbacks*) { this->update(provider); }

[nhiroki, 2015/07/31 06:56:32]

How do you switch implementation? IIUC, the next Chromium patch will break
"update(WebServiceWorkerProvider*)" version and layout tests will fail?

[nhiroki, 2015/07/31 07:02:58]

We could temporary disable tests to be broken in this CL and re-enable them in
the 3rd CL.

     virtual void unregister(WebServiceWorkerProvider*, WebServiceWorkerUnregistrationCallbacks*) { }
 };