Source/modules/serviceworkers/ServiceWorkerRegistration.idl - Issue 1267703003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.idl

Issue 1267703003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Overload WebServiceWorkerRegistration::update() to land patch sets across the repos. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | public/platform/WebServiceWorkerRegistration.h » ('j') | public/platform/WebServiceWorkerRegistration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerRegistration.idl

diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.idl b/Source/modules/serviceworkers/ServiceWorkerRegistration.idl

index c88cb42366a65c4624a7a5a91d8bd6c7e0a79849..982e93a48612018a5105cf7b10a24cf018b36a84 100644

--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.idl

+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.idl

@@ -15,7 +15,7 @@

readonly attribute USVString scope;

- [CallWith=ScriptState, RaisesException] void update();

+ [CallWith=ScriptState] Promise<void> update();

[CallWith=ScriptState] Promise<boolean> unregister();

attribute EventHandler onupdatefound;