Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 1267703003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 1267703003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Overload WebServiceWorkerRegistration::update() to land patch sets across the repos. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index 3e4acdce99e475e55ba56c2686907a394e6ed2e1..3f032d68e1597a1101be0ba5408e2f92b7453c7a 100644

--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -55,7 +55,7 @@ public:

WebServiceWorkerRegistration* webRegistration() { return m_outerRegistration.get(); }

- void update(ScriptState*, ExceptionState&);

+ ScriptPromise update(ScriptState*);

ScriptPromise unregister(ScriptState*);

DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | public/platform/WebServiceWorkerRegistration.h » ('J')